Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Deploy RelEng scripts in master branch build #2645

Merged

Conversation

HannesWell
Copy link
Member

This ensures that releng scripts are always updated on the download-server as soon as they change in the git repository. Furthermore this avoids the need for the separate Jenkins job to deploy the scripts, thus making
https://ci.eclipse.org/releng/job/Publish_shell_scripts_for_releng_jobs/ obsolete (can be deleted once this is submitted).

@HannesWell
Copy link
Member Author

Verified that this works by replaying the verification build and modified it to deploy to:

Will delete that entire folder again, together with the https://ci.eclipse.org/releng/job/Publish_shell_scripts_for_releng_jobs/ Jenkins job, once this is submitted.

@HannesWell HannesWell marked this pull request as draft December 7, 2024 11:04
@HannesWell
Copy link
Member Author

I have now added a 'staging' mechanism to minimize downtime, but I have to test this better.

@HannesWell HannesWell force-pushed the deploy-releng-scripts branch from d76e6a6 to 8f88aef Compare December 11, 2024 23:54
@HannesWell
Copy link
Member Author

With the latest adjustments and after some more testing I think this is now ready.
The result can be seen in my testing area at:

In general I would be nice to just start the deployment if something has changed, e.g. by uploading the commit-id of the current commit too and then running git diff before uploading, but I assume that's not worth the effort?

@HannesWell HannesWell marked this pull request as ready for review December 12, 2024 00:11
@akurtakov
Copy link
Member

Please get this one in and checks can be following commits.

@HannesWell HannesWell force-pushed the deploy-releng-scripts branch from 8f88aef to c9dab73 Compare December 12, 2024 20:17
This ensures that releng scripts are always updated on the
download-server as soon as they change in the git repository.
Furthermore this avoids the need for the separate Jenkins job to deploy
the scripts.
@HannesWell HannesWell force-pushed the deploy-releng-scripts branch from c9dab73 to 71f49a8 Compare December 12, 2024 20:50
@HannesWell
Copy link
Member Author

Please get this one in and checks can be following commits.

Yes. I just had it almost completely running quickly after my last message. So we have it with check now already. :)

Submitting now, as the verification build does not test this.

To bootstrap the state file this change I will have to Replay the master build with the modification that the git diff is skipped and the deployment happens unconditionally so that the state file is created initially.

@HannesWell HannesWell merged commit db10b04 into eclipse-platform:master Dec 12, 2024
3 of 4 checks passed
@HannesWell HannesWell deleted the deploy-releng-scripts branch December 12, 2024 20:53
@HannesWell
Copy link
Member Author

After unanticipated build failures on the initial run on master I figured out that the disposal location download.eclipse.org/eclipse/relengScripts-disposal was created by the genie.releng and can therefore not be deleted by the genie.platform:

 drwxr-sr-x   8 genie.platform eclipse.platform  4096 Dec 12 16:24 relengScripts/
 drwxr-sr-x   7 genie.releng   eclipse.platform  4096 Dec  8 12:30 relengScripts-disposal/

Deleting download.eclipse.org/eclipse/relengScripts-disposal from the releng JIPP (that uses the genie.releng) solved the problem now and the scripts could be deployed completely successful.
I'm going to delete the Publish_shell_scripts_for_releng_jobs job from the RelEng Jenkins now. It's now obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants