Trigger FocusIn event on Edge Browser focus #1499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HeikoKlare @fedejeanne @akoch-yatta we need to talk about what kind event should be sent to the listener and also what kind of events it should react to. For now my implementation fakes a mouse enter event on a mouseclick but we need to get the semantics right. |
amartya4256
force-pushed
the
edge_replaceInformationControl
branch
2 times, most recently
from
d5b2172 to
1126a35
Compare
amartya4256
force-pushed
the
edge_replaceInformationControl
branch
from
1126a35 to
1652c18
Compare
HeikoKlare
reviewed
Oct 16, 2024
| newEvent.widget = browser; | ||
| Point position = browser.getDisplay().getCursorLocation(); // To Points | ||
| position = browser.getDisplay().map(null, browser, position); | ||
| newEvent.x = position.x; newEvent.y = position.y; |
There was a problem hiding this comment.
nit: can you put these statements into separate lines?
amartya4256
force-pushed
the
edge_replaceInformationControl
branch
2 times, most recently
from
378382e to
641c477
Compare
This update ensures that the Edge browser triggers a FocusIn event for its listeners whenever the WebView gains focus. contributes to eclipse-platform#212
HeikoKlare
force-pushed
the
edge_replaceInformationControl
branch
from
641c477 to
f522412
Compare
HeikoKlare
changed the title
HeikoKlare
approved these changes
Oct 16, 2024
|
Closing this as superseded by #1551. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to the triggering of the event on mouseclick to replace an information control of the javadoc tooltip while using Edge Browser.
contributes to #1540