Expand Bar is not scaled during DPI change #1528
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 483 files ±0 483 suites ±0 8m 27s ⏱️ - 1m 41s For more details on these failures, see this check. Results for commit 661396e. ± Comparison against base commit a26b66a. ♻️ This comment has been updated with latest results. |
ShahzaibIbrahim
force-pushed
the
Master103-ExpandBar
branch
from
2c70881 to
1b48004
Compare
ShahzaibIbrahim
force-pushed
the
Master103-ExpandBar
branch
2 times, most recently
from
24acaa2 to
83e05b9
Compare
HeikoKlare
force-pushed
the
Master103-ExpandBar
branch
from
83e05b9 to
91058da
Compare
HeikoKlare
reviewed
Nov 5, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ExpandItem.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ExpandItem.java
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
Master103-ExpandBar
branch
2 times, most recently
from
f4c102c to
d27e04e
Compare
When using the monitor-specific rescaling functionality on Windows, moving a shell between monitors with different zoom levels (no matter which zoom levels they are), the images, expand items and texts are not drawn at correct coordinates. This change fixes the behavior to perform an appropriate layout update of the ExpandBar.
HeikoKlare
force-pushed
the
Master103-ExpandBar
branch
from
d27e04e to
661396e
Compare
|
For failing tests see: #1564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving from one zoom level monitor to another zoom level (no matter what %), The expanded items and texts are not drawn at correct coordinates.
HOW TO TEST
ControlExamplewith the following VM ArgumentsSCREENSHOTS
Before Fix:
After Fix:
Requires
Contributes to #62 and #127