-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Edge: Mouse events on DOM -> SWT mouse events #1545
Conversation
} | ||
@Override | ||
public Object function (Object[] arguments) { | ||
System.out.println(Arrays.toString(arguments)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I receive the mouse events just fine, e.g. in the "internal web browser".
But for some reason I do not receive any events in the element info popup or the variable hover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mouse events only seem to be processed when then content is retrieved from an "ordinary" URL. Whenever you set contents via setText
(such as in the Javadoc view, in the Java element info popup, in the help) it does not work. It does not depend on how the widget is embedded: in the help view, the first page is custom content (also with a custom context menu), which does not report mouse events, while when navigating to other entries in the help (like from the "see also" list), mouse events will be reported.
So it seems to be some problem of registering the browser function for "custom content" pages. Is it even possible to register browser functions to them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I thought as well at first, but it works perfectly fine with other setText()
-based browser usages, so does the following example:
public class Test {
public static void main(String[] args) {
Display display = Display.getDefault();
Shell shell = new Shell ();
shell.setLayout(new FillLayout());
new Browser(shell, SWT.EDGE).setText("hi");
shell.open ();
while (!shell.isDisposed()) {
if (!display.readAndDispatch ()) display.sleep ();
}
display.dispose ();
}
}
I don't understand what the element info / hover does differently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, easy one... It's simply that those use Browser.setJavascriptEnabled(false)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only affects scripts in the document; scripts injected with ExecuteScript will run even if script is disabled. It is true by default.
So we need to register those listeners on the window
, not the document
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, no dice. Doesn't make a difference... I guess this script-based approach won't be possible universally :(
Would resolve #1540.