Allow to configure Edge userdata directory via Display data

[amartya4256]

With this contribution, Edge browser uses the workspace directory for the userdata directory for the separation of the usage of userdata directory per workspace by the webview2Environment.

Depends on eclipse-platform/eclipse.platform.ui#2434

contributes to #1013

[iloveeclipse]

I'm not sure if workspace is the right place for user data of Edge browser that can be used on workspace free RCP applications.

[github-actions]

Test Results

   483 files  ±0     483 suites  ±0   8m 26s ⏱️ +6s
 4 095 tests ±0   4 085 ✅ ±0   7 💤 ±0  3 ❌ ±0 
16 173 runs  ±0  16 080 ✅ ±0  90 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 712bd2a. ± Comparison against base commit 6a2d73f.

♻️ This comment has been updated with latest results.

[HeikoKlare]

I'm not sure if workspace is the right place for user data of Edge browser that can be used on workspace free RCP applications.

I would rather propose to use the workspace directory whenever there is such a directory and in other cases use a different one (probably the ordinary user-data folder as used now).

In addition, SWT should not depend on the concept of a "workspace URL". There should rather be some "custom edge data folder", "display-specific edge data folder" or the like instead. Also, we cannot replace the usage of the existing system property, because people may still want to use that opportunity (in particular in plain SWT applicationS).

So what about using these values in decreasing preference:

• Use the value of the existing system property if provided?
• Use a value for some "custom edge data directory" defined as data in the display if specified (which can then be used by the Eclipse platform to define some specific value, may it workspace-dependent or not).
• Use the default value.

[laeubi]

I'm not sure what the edge user data directory is actually storing, but from OSGi perspective there is

https://docs.osgi.org/javadoc/osgi.core/8.0.0/org/osgi/framework/Bundle.html#getDataFile-java.lang.String-

[akurtakov]

I'm not sure what the edge user data directory is actually storing, but from OSGi perspective there is

https://docs.osgi.org/javadoc/osgi.core/8.0.0/org/osgi/framework/Bundle.html#getDataFile-java.lang.String-

SWT should stay usable in non-OSGi environment too.

[laeubi]

I'm not sure what the edge user data directory is actually storing, but from OSGi perspective there is
https://docs.osgi.org/javadoc/osgi.core/8.0.0/org/osgi/framework/Bundle.html#getDataFile-java.lang.String-

SWT should stay usable in non-OSGi environment too.

As far as I understand the settings/property is setup by the one who creates the display, so at that point OSGI might or might not be used.

Beside that, such thing can even be crafted in a way that is opaque for non-OSGi users, e.g with having an activator that initializes a static field, in non-OSGi env this will simply not happen and any default can be used instead.

[fedejeanne]

@HeikoKlare I extracted the method getDataDir(Display) and pushed the changes.

[HeikoKlare]

Test failures are unrelated and already documented:

• Random "Too many leaked file descriptors" in Test_org_eclipse_swt_browser_Browser #1523