Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland qt paste copy fix r4.29 #881

Conversation

the-snowwhite
Copy link
Contributor

@the-snowwhite the-snowwhite commented Nov 11, 2023

Update
This PR is superseded by #890

This is also for seeing if a build here could replace the #858 method.

Just for final testing of build errors. and because I have something wrong with all my SWT Eclipse build setups.
To see If They show virtual errors and warnings.
Update: the problems could be removed by deleting the unrelated projects including them.
...
Afterthought:
Hmmm this seems non conclusive how can I see if the binaries got built ?
This seems to be the culprit:

[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.2:compare-version-with-baselines
(compare-attached-artifacts-with-release) on project org.eclipse.swt: Only qualifier changed for 
(org.eclipse.swt/3.124.100.v20231111-0040). Expected to have bigger x.y.z than what is available in baseline 
(3.124.100.v20230825-1346)

Seems like something like the dependa-bot commit here is needed:
the-snowwhite@4daf005
To at least get this build to succeed ?

the-snowwhite and others added 3 commits November 11, 2023 01:13
…set=utf-8 to TextTransfer().

This makes it possible to paste into eclipse from a KDE/QT app in a
wayland session with gtkv3.24.33 and higher(ubuntu 22.04-LTS).
…ain;charset=utf-8 to the wayland

clipboard

Enables copy from eclipse to KDE/QT apps in a wayland session(RFC-1341)
Fix wrong implementation of TEXT_PLAIN_UTF8 transfer feature due to
commit 666b7fd
@the-snowwhite
Copy link
Contributor Author

the-snowwhite commented Nov 11, 2023

Suggestion thoughts
Note (to self) 1
If the Releng builds could be made able to provide the build artifacts to the users (Like in current Machinekit).
It would make i much easier to test PR's and make the #858 as easy as;
download, rename 3 files(could be skiped if the build names them correctly), copy them in plugins folder, test in your current Stable Eclipse release.(Or whatever there are branches for).

@the-snowwhite
Copy link
Contributor Author

the-snowwhite commented Nov 11, 2023

Note (to self) 2
The Reling build is here:
https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/PR-881/
This build does not have the console and does not run the same tests and error checking as the mvn build ?

@the-snowwhite
Copy link
Contributor Author

Question:
https://github.com/eclipse-platform/eclipse.platform.swt/pull/881/checks?check_run_id=18579816053

Commit SWT-native binaries, if build (11 sec)
Build (running)

what does this mean and why is it taking so long time ?

@the-snowwhite
Copy link
Contributor Author

Note 3 (to self)
There is now a build here with console but still not the usual error checks.
https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/PR-881/1/

@the-snowwhite
Copy link
Contributor Author

Note (to self 5)
OK the console is still active and its just come to the:
+ mvn clean verify --batch-mode -DforkCount=0 -Dcompare-version-with-baselines.skip=false -Dmaven.compiler.failOnWarning=true -Dmaven.test.failure.ignore=true -Dmaven.test.error.ignore=true
step

@the-snowwhite
Copy link
Contributor Author

I created an issue hoping to find a solution.
#885

@mickaelistria
Copy link
Contributor

Please also add a commit that change the bundle version (in MANIFEST.MF) by +0.0.1 as part of this same PR; because this change is the 1st one happening since last release, and Eclipse project only change the version once there is an actual change (keeps previous version if there is no change).

@the-snowwhite
Copy link
Contributor Author

This PR is superseded by #890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants