[WIP] [E4 Xpath] Replace apache.commons.jxpath by javax.xml.xpath #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a queue, one can simply use eAllContents() to get a tree iterator over all elements. One one is created for each node, which is then attached to its container.
|
@HannesWell As the tests will hopefully show, the current state should support generic XPaths such as |
Test Results 1 818 files ±0 1 818 suites ±0 1h 30m 3s ⏱️ - 3m 3s For more details on these failures, see this check. Results for commit dc9d2d4. ± Comparison against base commit 4e0740d. This pull request removes 3 and adds 6 tests. Note that renamed tests count towards both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #2290 and attempts to perform an XPath evaluation of the EObjects via the native javax.xml.xpath API rather than relying on JXPath. The Java model is converted to an XML structure where each EObject is mapped to a DOM node. The XPath is applied on the root node and the resulting nodes are then converted back to EObjects.