Consider Activity Filtering when running in E3 compatibility mode #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
consider_activity_filterings
branch
from
5556d16 to
92276ec
Compare
Test Results 1 821 files ±0 1 821 suites ±0 1h 30m 24s ⏱️ - 5m 14s For more details on these failures, see this check. Results for commit c2a8a4c. ± Comparison against base commit 8c2be45. ♻️ This comment has been updated with latest results. |
...s.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/DynamicContributionContributionItem.java
Outdated
Show resolved
Hide resolved
...org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/WorkbenchContributionFactory.java
Outdated
Show resolved
Hide resolved
laeubi
force-pushed
the
consider_activity_filterings
branch
from
92276ec to
1b4b00b
Compare
laeubi
force-pushed
the
consider_activity_filterings
branch
from
1b4b00b to
2ac26c2
Compare
|
Please also bump dependencies required here: |
laeubi
force-pushed
the
consider_activity_filterings
branch
from
2ac26c2 to
0a4af9b
Compare
|
Lower versions updated |
iloveeclipse
approved these changes
Jan 31, 2025
|
I merged the other PR but we will need to wait for the next Ibuild until this one can succeed. |
iloveeclipse
force-pushed
the
consider_activity_filterings
branch
from
0a4af9b to
accf339
Compare
|
I haven't looked into details, but there are many e4 test fails caused by the change: |
|
I will take a look |
Currently contributions by E4 are not filtered using the E3 activity mechanism as it is a pure E3 concept. To improve integration and interaction of E4 and E3 when using the compatibility layer this now installs a WorkbenchContributionFactory into the application context that additionally takes activity filtering of the E3 workbench into account. See eclipse-platform#2217
laeubi
force-pushed
the
consider_activity_filterings
branch
from
accf339 to
c2a8a4c
Compare
|
The problem was that handled items have no contributor (to support these one must possibly lookup the command/handler and then check if that contribution is active but I will ignore this for now). |
|
Looks good now! |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently contributions by E4 are not filtered using the E3 activity mechanism as it is a pure E3 concept.
To improve integration and interaction of E4 and E3 when using the compatibility layer this now installs a WorkbenchContributionFactory into the application context that additionally takes activity filtering of the E3 workbench into account.
See
Requires: