Prevent StatusLine from SWT Invalid thread access #2792
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ProgressDialog would also deserve to be fixed together with this change. |
Since monitor methods may be invoked from any thread, make sure we wrap all SWT operations in UI Thread. Fixes eclipse-jdt/eclipse.jdt.core#3718
akurtakov
force-pushed
the
statusline-uithread
branch
from
a01c7f7 to
1319d28
Compare
|
Do you plan to get this one finished? |
|
This one is currently insufficient (see my last comment about ProgressDialog) and the initial user story behind it is very low priority. Let's abandon for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since monitor methods may be invoked from any thread, make sure we wrap all SWT operations in UI Thread.
Fixes eclipse-jdt/eclipse.jdt.core#3718