Skip to content

Add SVGs to org.eclipse.ui.views bundles #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Michael5601
Copy link
Contributor

@Michael5601 Michael5601 commented Apr 15, 2025

This PR adds SVGs for all icons in the bundles org.eclipse.ui.views and org.eclipse.ui.views.log.

See also this PR for more information.

@Michael5601 Michael5601 force-pushed the org.eclipse.ui.views.log.SVGs branch from a2343c2 to b9ed6de Compare April 15, 2025 13:20
@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Apr 15, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
bundles/org.eclipse.ui.views/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 977fb95efd316b3b5a48bed4b217038395574db4 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sat, 26 Apr 2025 15:48:48 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
index 80a87da8a0..6849404e49 100644
--- a/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.ui.views.log;singleton:=true
-Bundle-Version: 1.4.700.qualifier
+Bundle-Version: 1.4.800.qualifier
 Bundle-Activator: org.eclipse.ui.internal.views.log.Activator
 Bundle-Vendor: %provider-name
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
diff --git a/bundles/org.eclipse.ui.views/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.views/META-INF/MANIFEST.MF
index 694f84df8b..6ff5185d63 100644
--- a/bundles/org.eclipse.ui.views/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.views/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.views; singleton:=true
-Bundle-Version: 3.12.500.qualifier
+Bundle-Version: 3.12.600.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.ui.internal.views.contentoutline;x-internal:=true,
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@HeikoKlare HeikoKlare force-pushed the org.eclipse.ui.views.log.SVGs branch from b9ed6de to 7a0b88f Compare April 24, 2025 15:26
Copy link
Contributor

github-actions bot commented Apr 24, 2025

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 31m 34s ⏱️ - 3m 22s
 7 918 tests ±0   7 690 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 841 runs  ±0  23 093 ✅ ±0  748 💤 ±0  0 ❌ ±0 

Results for commit 8d3a54c. ± Comparison against base commit 769ddf9.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the org.eclipse.ui.views.log.SVGs branch from a6d4988 to b1e4047 Compare April 26, 2025 16:32
Michael5601 and others added 3 commits April 26, 2025 18:32
This commit adds SVGs for all icons in the bundles `org.eclipse.ui.views` and `org.eclipse.ui.views.log`.
Use on-the-fly-generated disabled version of SVG-rasterized icons
instead.
@HeikoKlare HeikoKlare force-pushed the org.eclipse.ui.views.log.SVGs branch from b1e4047 to 8d3a54c Compare April 26, 2025 16:33
@HeikoKlare HeikoKlare merged commit 2e51edb into eclipse-platform:master Apr 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants