Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSGi-API-bundles to features #39

Closed

Conversation

HannesWell
Copy link
Member

This PR adds the OSGi-bundles from Maven-Central that replace the formerly embedded OSGi source-code to those Features that contain the Plug-ins whose OSGi-sources are replaced.
The motivation to add the OSGi-bundles to the features is mainly to also have their sources included into the p2-repos of the Eclipse-SDK.

This is part of eclipse-equinox/equinox#18 and should be submitted after eclipse-equinox/equinox.framework#41, eclipse-equinox/equinox.framework#44 and eclipse-equinox/equinox.bundles#26 are merged.

@HannesWell
Copy link
Member Author

This PR suffers the same problem like eclipse-equinox/equinox.framework#44 (comment)

@HannesWell
Copy link
Member Author

Since it looks like the associated changes in the plug-ins to replace the osgi-bundles will be submitted at different point of time and the next M2 happens soon I think the replacing OSGi-bundles should be included into features ASAP.
Therefore I have split this PR into multiples where each PR includes those OSGi-bundles that are now referenced by the plug-ins changed in the associated 'Plug-in change'-PR. This also simplifies the review process because the change is smaller.

So this PR is superseded by:

@HannesWell HannesWell closed this Apr 27, 2022
@HannesWell HannesWell deleted the osgiBundlesInFeatures branch April 27, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant