Replace calls to CoreTest.assertEquals() with matcher statements #903 #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pse-platform#903 Replaces all calls to CoreTest.assertEquals() for comparing array contents with matcher statements. This makes the assertions independent from JUnit 3 and improves the provided error messages in case of a test failure. The change also improves the other assertions in the touched test classes. Contributes to eclipse-platform#903
HeikoKlare
force-pushed
the
remove-coretest-assertequals-calls
branch
from
65f0409 to
3439ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all calls to CoreTest.assertEquals() for comparing array contents with matcher statements. This makes the assertions independent from JUnit 3 and improves the provided error messages in case of a test failure. The change also improves the other assertions in the touched test classes.
Contributes to #903