Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdf4j-rio-rdfjson incompatible with Jackson 2.7+ #273

Closed
ansell opened this issue Aug 3, 2016 · 2 comments
Closed

rdf4j-rio-rdfjson incompatible with Jackson 2.7+ #273

ansell opened this issue Aug 3, 2016 · 2 comments
Labels
🐞 bug issue is a bug
Milestone
2.0

Comments

@ansell
Copy link
Contributor

ansell commented Aug 3, 2016

Currently the RDF4J code is using a method in rdf4j-rio-rdfjson (Lf2SpacesIndenter) that doesn't exist in Jackson 2.7+ as Jackson have a policy where they remove public APIs across minor versions. It is simple to fix without changing the version of Jackson that legal has approved for distribution, but will change the range of Jackson versions that we are compatible with. They had deprecated the API before introducing a new named public API that does exactly the same thing in a newer version and the replacement exists in 2.6 that we have legal approval for.
@ansell
Copy link
Contributor Author

ansell commented Aug 3, 2016

Tracking issue for asking jackson maintainers what their public API versioning policy is:

FasterXML/jackson-core#308

The commit that broke compatibility is:

FasterXML/jackson-core@f8d8856

@ansell
Copy link
Contributor Author

ansell commented Aug 3, 2016

I will work on a pull request for this.

This was referenced Aug 3, 2016
Closed
Merged
abrokenjester added a commit that referenced this issue Aug 4, 2016
@abrokenjester
Merge pull request #275 from ansell/issues/#273-rdfjson-jackson
df4391c 
issue#273 : Use non-deprecated methods to be compatible with jackson2.7+
@abrokenjester abrokenjester added the 🐞 bug issue is a bug label Aug 8, 2016
@abrokenjester abrokenjester added this to the 2.0 milestone Aug 8, 2016
@abrokenjester abrokenjester mentioned this issue Aug 31, 2016
Closed
abrokenjester pushed a commit that referenced this issue Aug 22, 2019
Merge pull request #273 from eclipse/issues/GH-506-externalset
073ee66 
marked ExternalSet as deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug issue is a bug
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@ansell @abrokenjester