Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4718 optimize approvedEmpty and deprecatedEmpty #4719

Closed
wants to merge 1 commit into from

Conversation

hmottestad
Copy link
Contributor

GitHub issue resolved: #4718

Briefly describe the changes proposed in this PR:


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

…ved models so that we can update the approvedEmpty and deprecatedEmpty more efficiently
@hmottestad
Copy link
Contributor Author

hmottestad commented Aug 5, 2023

Before

Benchmark                                               Mode  Cnt      Score      Error  Units
OverflowBenchmarkSynthetic.loadLotsOfDataEmptyStore     avgt   10  11525.521 ± 2709.930  ms/op
OverflowBenchmarkSynthetic.loadLotsOfDataNonEmptyStore  avgt   10  17358.805 ± 5673.566  ms/op

After

Benchmark                                               Mode  Cnt      Score      Error  Units
OverflowBenchmarkSynthetic.loadLotsOfDataEmptyStore     avgt   10  13667.451 ± 6103.327  ms/op
OverflowBenchmarkSynthetic.loadLotsOfDataNonEmptyStore  avgt   10  17120.881 ± 9069.072  ms/op

@hmottestad hmottestad closed this Aug 6, 2023
@hmottestad hmottestad deleted the GH-4718-optimize-changeset-empty-fields branch August 6, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize approvedEmpty and deprecatedEmpty in Changeset
1 participant