Features/bsh/25.1/378432 cell editor popup #1350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a keystroke is triggered on a descendant of the cell editor field, the cell editor popup should not be closed. This should also work if the descendant is not rendered within the cell editor popup's $container. Consider a cell editor that opens a form that also has an editable column. If the inner cell editor is closed with Enter, the outer cell editor popup should not be completed automatically. Instead of checking if the keystroke's scope target is part of the $container, we also check the widget hierarchy of the scope target. If it belongs to the cell editor, we don't trigger completeEdit(). Note: This does not work for forms by default, because they always override their 'parent' property with the 'displayParent' (see Form#_setDisplayParent). To allow the CellEditorPopup to properly recognize the widget hierarchy, the parent has to be restored to the cell editor field after the form has been created by manually calling Form#setParent. 378432
When a form field is used as a cell editor of an editable table, it often needs some adjustments. Previously, only a few selected properties (e.g. "mode") were updated by the Column and CellEditorPopup classes. These property adjustments were moved to the new method FormField#activateCellEditorMode. This allows subclasses to add their own adjustments by overriding this method. 378432
cguglielmo
reviewed
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.