Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Step 3 #155

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Refactor Step 3 #155

merged 3 commits into from
Oct 19, 2023

Conversation

heliocastro
Copy link
Contributor

Big refactor on Object Types
Components realigned

@heliocastro
Copy link
Contributor Author

@hoangnt2 Big one this one, it took me some hours.
Somehow i broke the authentication somewhere, and if you can use your skills to spot error, i appreciate

Signed-off-by: Helio Chissini de Castro <[email protected]>
@heliocastro heliocastro force-pushed the heliocastro/refactor_step3 branch from e3d61d5 to 99c347f Compare October 19, 2023 07:15
@hoangnt2
Copy link
Contributor

@heliocastro sure, let me check it

@hoangnt2
Copy link
Contributor

@heliocastro I don't see any error, could you show me where you got the authentication error?

@heliocastro
Copy link
Contributor Author

@hoangnt2 Locally i can't login anymore with my regular email/password
Did something changed on sw360 that i need recompile ?

@heliocastro heliocastro force-pushed the heliocastro/refactor_step3 branch from b918214 to d63f470 Compare October 19, 2023 08:01
@hoangnt2
Copy link
Contributor

@heliocastro I can login normally, i guess maybe you are missing oauth client in sw360

@hoangnt2
Copy link
Contributor

@heliocastro, By the way, I got this error on the vulnerability page. When I replace the Link component from next-intl/link with next/link the error goes away. Do you know the reason?
image

messages/en.json Outdated Show resolved Hide resolved
@heliocastro
Copy link
Contributor Author

heliocastro commented Oct 19, 2023

@heliocastro, By the way, I got this error on the vulnerability page. When I replace the Link component from next-intl/link with next/link the error goes away. Do you know the reason? image

Yes, of course.
netx-intl depends on "use-client'
But even after adding it, fails continues, because the Table entries
Inside the table we have React objects as a React component created dynamically per row, that think itself as a server component.

In this case, we are passing a client component inside a server component, and then, the warnings

    const columns = [
        {
            id: 'vulnerabilities.externalId',
            name: t('External Id'),
            formatter: (externalId: string) =>
                _(
                    <>
                        <Link href={`/vulnerabilities/detail/${externalId}`} className='text-link'>
                            {externalId}
                        </Link>
                    </>
                ),
            sort: true,
        },

@hoangnt2
Copy link
Contributor

@heliocastro, Oh thanks I got it

@heliocastro heliocastro removed help wanted Extra attention is needed WIP breaking change labels Oct 19, 2023
@heliocastro heliocastro merged commit 959bbd7 into main Oct 19, 2023
2 checks passed
@heliocastro heliocastro deleted the heliocastro/refactor_step3 branch October 19, 2023 08:35
@heliocastro
Copy link
Contributor Author

@hoangnt2 Merged, so this should be officially last breaking change.
From now on, i will do more atomic commits.
Is working on my side the auth now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants