-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Step 3 #155
Refactor Step 3 #155
Conversation
@hoangnt2 Big one this one, it took me some hours. |
Signed-off-by: Helio Chissini de Castro <[email protected]>
e3d61d5
to
99c347f
Compare
@heliocastro sure, let me check it |
@heliocastro I don't see any error, could you show me where you got the authentication error? |
@hoangnt2 Locally i can't login anymore with my regular email/password |
Somehow Git lost the case change
b918214
to
d63f470
Compare
@heliocastro I can login normally, i guess maybe you are missing oauth client in sw360 |
@heliocastro, By the way, I got this error on the vulnerability page. When I replace the Link component from next-intl/link with next/link the error goes away. Do you know the reason? |
Yes, of course. In this case, we are passing a client component inside a server component, and then, the warnings const columns = [
{
id: 'vulnerabilities.externalId',
name: t('External Id'),
formatter: (externalId: string) =>
_(
<>
<Link href={`/vulnerabilities/detail/${externalId}`} className='text-link'>
{externalId}
</Link>
</>
),
sort: true,
}, |
@heliocastro, Oh thanks I got it |
@hoangnt2 Merged, so this should be officially last breaking change. |
Big refactor on Object Types
Components realigned