refactor(requests): Refactor requests folder #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deo002
force-pushed
the
refactor/requests
branch
from
e4fd18a to
6406fa9
Compare
hoangnt2
reviewed
Dec 17, 2024
| return null | ||
| async (url: string, signal: AbortSignal) => { | ||
| try { | ||
| if (CommonUtils.isNullOrUndefined(session)) return signOut() |
There was a problem hiding this comment.
I know you are working on this PR, but I have a comment. If you use useSession(), there is a delay (loading time) before the session is retrieved. So, if you call this fetch function inside useEffect() and the session has not been retrieved yet, the user might be logged out. I think you should use getSession() instead to avoid that problem.
deo002
force-pushed
the
refactor/requests
branch
from
6406fa9 to
b1bf370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.