Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(licenses): adding support for project-only obligations #517

Merged
merged 2 commits into from
Jul 18, 2019
Merged

feat(licenses): adding support for project-only obligations #517

merged 2 commits into from
Jul 18, 2019

Conversation

thegrumpylion
Copy link

This change introduces a new portlet for managing TODOs under the Admin
menu. There are 2 views. One for listing TODOs saved in the database and
one for adding a new one. In the listing view, the delete action is also
available but can only be executed by users with SW360_ADMIN rights and
above.

Signed-off-by: Nikolas Sepos [email protected]

@mcjaeger mcjaeger added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for WIP work in progress and removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Apr 25, 2019
@thegrumpylion thegrumpylion force-pushed the nikolas/todos branch 2 times, most recently from a176314 to 1676398 Compare April 25, 2019 13:19
@mcjaeger mcjaeger added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for has merge conflicts and removed WIP work in progress labels Apr 26, 2019
@mcjaeger mcjaeger self-requested a review May 8, 2019 18:44
mcjaeger
mcjaeger requested changes May 8, 2019
View reviewed changes
Copy link
Contributor

@mcjaeger mcjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not do code reivew, but... there seems to be a glitch both on FF 66 and safari 12, because the main text field seems to be small, not using the entire width:
Screen Shot 2019-05-08 at 20 43 15 1
Maybe it could be changed in width.

@mcjaeger mcjaeger removed the needs general test This is general testing, meaning that there is no org specific issue to check for label May 9, 2019
@thegrumpylion
Copy link
Author

I'll take care of it

@mcjaeger
Copy link
Contributor

https://github.com/eclipse/sw360/wiki/Dev-DoD-and-Style ... commit message should be like feat(licenses): adding support for project-only obligations

@thegrumpylion
Copy link
Author

Ref: siemens#19

@thegrumpylion
Copy link
Author

https://github.com/eclipse/sw360/wiki/Dev-DoD-and-Style ... commit message should be like feat(licenses): adding support for project-only obligations

Ah, thanks for the pointer.

@mcjaeger
Copy link
Contributor

tested again and looks OK

@mcjaeger
Copy link
Contributor

@thegrumpylion test seem to fail ... I think you can check the log output from the CI run. Since your works are related to the license infoemation I suspect it might be connected with your PR. Could you please have a look?

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 09:05 min
[INFO] Finished at: 2019-05-15T00:21:21Z
[INFO] Final Memory: 205M/821M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project src-licenses: Compilation failure
[ERROR] /home/travis/build/eclipse/sw360/backend/src/src-licenses/src/main/java/org/eclipse/sw360/licenses/db/LicenseDatabaseHandler.java:[906,43] cannot find symbol
[ERROR]   symbol:   variable UserGroup
[ERROR]   location: class org.eclipse.sw360.licenses.db.LicenseDatabaseHandler
[ERROR] 
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :src-licenses
The command "mvn --fail-at-end $MVN_ARGS" exited with 1.

@mcjaeger mcjaeger added the WIP work in progress label May 17, 2019
@thegrumpylion thegrumpylion force-pushed the nikolas/todos branch 2 times, most recently from 0a82e89 to bb1d89b Compare May 27, 2019 07:19
@thegrumpylion thegrumpylion changed the title TODOs Management feat(licenses): adding support for project-only obligations May 28, 2019
@mcjaeger mcjaeger removed the WIP work in progress label May 29, 2019
@thegrumpylion thegrumpylion force-pushed the nikolas/todos branch 3 times, most recently from 2c5391f to 738fdd6 Compare July 2, 2019 23:12
feat(licenses): add support for project-only obligations
28d252e 
This change introduces a new portlet for managing TODOs under the Admin
menu. There are 2 views. One for listing TODOs saved in the database and
one for adding a new one. In the listing view, the delete action is also
available but can only be executed by users with SW360_ADMIN rights and
above.

This new PrivatePages.lar includes the TODOs management portlet.

Signed-off-by: Nikolas Sepos <[email protected]>
@mcjaeger mcjaeger added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for and removed WIP work in progress labels Jul 10, 2019
@mcjaeger mcjaeger added this to the Release sw360-3.4.0-M1 milestone Jul 11, 2019
@mcjaeger mcjaeger self-assigned this Jul 11, 2019
@mcjaeger mcjaeger self-requested a review July 15, 2019 11:53
mcjaeger
mcjaeger requested changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@mcjaeger mcjaeger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a deployment using sw360vagrant:

Screen Shot 2019-07-15 at 13 54 29

values for "did fulfill" are not stored, neither existing project nor new one: following flow:

  1. create a project and check the check box for some bogus todo "rest":

Screen Shot 2019-07-15 at 13 49 32

  1. Save it and it looks like:

Screen Shot 2019-07-15 at 13 49 54

(nothing saved w.r.t. obligations)

  1. edit again, this time both obligations:

Screen Shot 2019-07-15 at 13 50 06

  1. looks successful:

Screen Shot 2019-07-15 at 13 50 14

  1. but not for the values for obligations:

Screen Shot 2019-07-15 at 13 50 23

Remarks

  1. tested with admin and clearing admin level also project in screenshot was created by clearing admin.
  2. No exception in this logs

@mcjaeger
Copy link
Contributor

cleared FF caches and files to be 100% sure about my testing -> then it works !!!

mcjaeger
mcjaeger approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@mcjaeger mcjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retest with cleared caches: works ...

This was referenced Jul 18, 2019
Closed
Closed
@lepokle lepokle dismissed imaykay’s stale review July 18, 2019 20:04

Reviewer is in vacation.

@lepokle lepokle removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jul 18, 2019
@lepokle
Copy link
Contributor

lepokle commented Jul 18, 2019

UI glitches will be fixed with #398

@lepokle lepokle merged commit a583a35 into eclipse-sw360:master Jul 18, 2019
lepokle added a commit to siemens/sw360 that referenced this pull request Jul 19, 2019
@lepokle
feat(todoMigration): migration script for todos
c63d656 
This commits add a migration script for changing the 'todoId' into
the 'title' for todo documents.

This is necessary due to the changes in eclipse-sw360#517.

Closes eclipse-sw360#586

Signed-off-by: Leo von Klenze <[email protected]>
lepokle added a commit to siemens/sw360 that referenced this pull request Jul 19, 2019
@lepokle
feat(todoMigration): migration script for todos
419a94d 
This commits add a migration script for changing the 'todoId' into
the 'title' for todo documents.

This is necessary due to the changes in eclipse-sw360#517.

Closes eclipse-sw360#586

Signed-off-by: Leo von Klenze <[email protected]>
lepokle added a commit to siemens/sw360 that referenced this pull request Jul 19, 2019
@lepokle
feat(todoMigration): migration script for todos
5cdd320 
This commits add a migration script for changing the 'todoId' into
the 'title' for todo documents.

This is necessary due to the changes in eclipse-sw360#517.

Closes eclipse-sw360#586

Signed-off-by: Leo von Klenze <[email protected]>
@lepokle lepokle mentioned this pull request Jul 19, 2019
Merged
lepokle added a commit that referenced this pull request Jul 22, 2019
@lepokle
feat(todoMigration): migration script for todos
ee7b374 
This commits add a migration script for changing the 'todoId' into
the 'title' for todo documents.

This is necessary due to the changes in #517.

Closes #586

Signed-off-by: Leo von Klenze <[email protected]>
maxhbr pushed a commit to boschglobal/sw360 that referenced this pull request Jul 24, 2019
@lepokle @maxhbr
feat(todoMigration): migration script for todos
c728468 
This commits add a migration script for changing the 'todoId' into
the 'title' for todo documents.

This is necessary due to the changes in eclipse-sw360#517.

Closes eclipse-sw360#586

Signed-off-by: Leo von Klenze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imaykay imaykay imaykay left review comments

@mcjaeger mcjaeger mcjaeger approved these changes

Assignees

@mcjaeger mcjaeger

Labels
None yet
Projects
None yet
Milestone
Release sw360-3.4.0-M1
Development

Successfully merging this pull request may close these issues.
4 participants
@thegrumpylion @mcjaeger @imaykay @lepokle