Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app scope to target object #616

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

linyguo
Copy link
Contributor

@linyguo linyguo commented Jan 21, 2025

Add appScope in target spec to allow configuring application scopes from target.

  1. If instance has defined scope, use the scope in instance spec.
  2. If instance doesn't have a scope, use the scope defined in target spec. If both are not defined, fall back to the default scope.
  3. If both instance and target spec defined a scope, will check if the two fields are equivalent. If not, a warning message will be logged and the scope defined in instance spec will be used.

add diagnostic log

add diagnostic log
Copy link
Contributor

@msftcoderdjw msftcoderdjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with this change, but please work with @yanjiaxin534 when remote-agent pr to main, this part may be conflict a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants