Remote Agent Part1: bootstrap #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwangjintian
requested review from
Haishi2016 and
msftcoderdjw
as code owners
msftcoderdjw
approved these changes
Jan 27, 2025
| // Set the spec fields | ||
| spec := map[string]interface{}{ | ||
| "secretName": secretName, | ||
| "duration": "2160h", // 90 days |
There was a problem hiding this comment.
Make these two values configurable.
| target, err := c.TargetsManager.GetState(ctx, id, namespace) | ||
| if err != nil { | ||
| tLog.InfofCtx(ctx, "V (Targets) : onBootstrap target %s in namespace %s not found", id, namespace) | ||
| err := json.Unmarshal(request.Body, &target) |
There was a problem hiding this comment.
User new JsonUnmarshal function.
| }) | ||
| } | ||
| var topology model.TopologySpec | ||
| json.Unmarshal(request.Body, &topology) |
There was a problem hiding this comment.
New Json unmarshal function
| assert.NotNil(t, authResponse.AccessToken) | ||
| assert.Equal(t, "Bearer", authResponse.TokenType) | ||
| } | ||
| // func TestTargetsOnBootstrap(t *testing.T) { |
| } | ||
| fs := &fasthttp.FS{ | ||
| Root: "/", // Directory to serve files from | ||
| IndexNames: []string{"index.html"}, |
| key: "tls.crt" | ||
|
|
||
| - inLine: | | ||
| -----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
should we keep this inline?
| echo "private.pem" | ||
| echo "remote-agent" | ||
|
|
||
| ./remote-agent -config=$config -client-cert=./public.pem -client-key=./private.pem -target-name=$target_name -namespace=$namespace -topology=$topology |
| @@ -0,0 +1,21 @@ | |||
| -----BEGIN CERTIFICATE----- | |||
There was a problem hiding this comment.
I doubt you cannot have this file checked in, especially when we backport this to extension repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap changes are :
Symphony control plane side to enable cert based authentication
Symphony control plane side to trust specific CAs
Symphony control plane side to trust specific subjectNames
Symphony control plane side to have a file server to download agent
Agent side to call file server to download symphony agent
Agent side to call bootstrap endpoint
The bootstrap would exchange bootstrap certificate for working certificate. The bootstrap certificate now is pre-defined. (I randomly created a self-signed CA from cert manager and issued one client cert)
The bootstrap script would do this and start the agent. (we have a task to run the agent as a service)
The agent would use the topology.json to render the providers for it. And the http binding in remote agent serves purely as a client.