Remote Agent Part2: add remote-agent provider to support SR and upgrade #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwangjintian
requested review from
Haishi2016 and
msftcoderdjw
as code owners
| @@ -29,6 +29,7 @@ type ActivationsCleanupManager struct { | |||
| } | |||
|
|
|||
| func (s *ActivationsCleanupManager) Init(ctx *vendorCtx.VendorContext, config managers.ManagerConfig, providers map[string]providers.IProvider) error { | |||
| s.ActivationsManager = ActivationsManager{} | |||
There was a problem hiding this comment.
This line is redundant since we keep object other than reference. It will be initialized automatically.
| clientset := fake.NewSimpleClientset() | ||
| os.Setenv("AGENT_VERSION", "0.0.0.1") | ||
|
|
||
| cert := []byte(`-----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
plain text secret may raise alert in ADO.
| @@ -16,7 +16,6 @@ import ( | |||
| "os" | |||
There was a problem hiding this comment.
Not change this file. The script target provider is not for adhoc execution. It is for target script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review part 1 before 2
After bootstrap is done, we added SR and upgrade in the remote agent provider
We also changed the script provider a bit to allow it to run script like script stage provider (makes more sense to run custom script on remote side)