Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: use bundled backend in launch configurations #453

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Feb 6, 2025

What it does

Adapts the browser launch configurations to use the bundled backend. This allows to start the browser application after it was built once, independent of the current state of the native Node module dependencies.

How to test

  • Built the Browser application
  • Build the Electron application
  • Use the launch configuration to start the Browser application
  • Observe that it now succeeds to start

Review checklist

Reminder for reviewers

Adapts the browser launch configurations to use the bundled backend.
This allows to start the browser application after it was built once,
independent of the current state of the native Node module
dependencies.
@sdirix sdirix requested a review from jfaltermeier February 6, 2025 09:15
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@sdirix sdirix merged commit 1609442 into master Feb 6, 2025
5 checks passed
@sdirix sdirix deleted the improve-launch-configs branch February 6, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants