Clean repo #1
Merged
Clean repo #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 16, 2023 10:08
ethieblin
force-pushed
the
clean_repo
branch
4 times, most recently
from
b07321e
to
1fe9d4a
Compare
Let's use a more "neutral" naming for our implementation.
wiresio
reviewed
Aug 18, 2023
There was a problem hiding this comment.
@ethieblin - do we need this empty file?
There was a problem hiding this comment.
That's weird, if you click on "View file" it is not empty: https://github.com/wiresio/tdd-api/blob/5ac31f51d5c41c8ab567f3f038295058f8537596/tdd/data/fixed-discovery-ctx.json
It is true that it is not used anymore because there is no need to overwrite the discovery context anymore, but I thought maybe we can keep it if we need to overwrite this context again someday ?
wiresio
approved these changes
Aug 18, 2023
|
Fine for me to merge. Just had one comment about the empty "tdd-discovery" context file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to test the Workflow (github actions)