Add workaround for missing content types in response fields, use correct affordance keys #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 25, 2024 17:37
If parameter `format` is not in ['array', 'collection'] returns an appropriate error message.
JKRhb
force-pushed
the
fix-td-validation
branch
2 times, most recently
from
fdfcf95
to
1ebf4eb
Compare
JKRhb
force-pushed
the
fix-td-validation
branch
from
6df43e0
to
e51b12d
Compare
|
This PR now also contains the changes made by @Murloc6 in their PR and should only be merged afterward. |
|
Thanks Jan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the workaround needed to resolve #13. It is based on a similar PR (vaimee/zion#52) I submitted to ZION dealing with the same issue.
While working on this issue, I noticed that the TDD's TD did not use the correct affordance keys to be compliant with the Discovery specification (c.f. the Thing Model in section 7.3.2.4). Therefore, I also adjusted the keys to improve the directory's interoperability.