Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pypi packaging #6

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Pypi packaging #6

merged 6 commits into from
Apr 26, 2024

Conversation

ethieblin
Copy link

This PR does the following in the purpose of a future publication on pypi.org:

  • Update the package metadata
  • Update the MANIFEST.in (used for python packaging)
  • Change the way the JavaScript files are loaded so that the user can only "pip install" the package and does not have to perform any other node related command before using the package

@ethieblin
Copy link
Author

cc @wiresio

Copy link
Member

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also where can I see the planned owner or org on pypi? We are still waiting for them to set the org

setup.py Outdated Show resolved Hide resolved
@ethieblin
Copy link
Author

The metadata contained in the setup.py is what will appear on pypi as author/maintainer name and email.
A good practice would be to add an email for author/maintainer, for example, if you have one for the Eclipse Thingweb Project contact list.

What we usually do in my company is that we share a pypi token of the company account and publish python project using this token. But this is in the local .pypirc and does not appear on the repository or package metadata.

Regarding the pypi account publishing to the pypi project (therefore the one creating it): we will have to wait for the eclipse project to have its own account and create its own token ? Or if you have another method to publish it under the Eclipse Thingweb Project name, I trust you.

In any case, I will not publish this package without a pypi token or direct orders from your side. I think it is best if you publish it the way you want on your side.

@egekorkan
Copy link
Member

Regarding publishing, thanks for the clarification. We are attempting to get an organization account so that multiple people can publish without sharing any account or token information with each other. It is a bit of a pain though, see pypi/support#3787 where the request is ongoing since December. We have triggered our Eclipse contacts to see if they can get into touch with someone in PyPi. In the worst case, we will create a normal account and share the token/key privately. If we ever get an organization account, the project can be moved there.

@wiresio wiresio merged commit 0bb2a8d into eclipse-thingweb:main Apr 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants