-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identifier jvm info #126
base: master
Are you sure you want to change the base?
Identifier jvm info #126
Conversation
The rest.core plug-in version is retrieved to show in the identifier service. This is the only way to retrieve the version programmatically and hence the plug-in version and release version has to match. Signed-off-by: Bernd Hufmann <[email protected]>
The rest.core plug-in version is retrieved to show in the identifier service. This is the only way to retrieve the version programmatically and hence the plug-in version and release version has to match. Signed-off-by: Bernd Hufmann <[email protected]>
fixes eclipse-tracecompass-incubator#121 Signed-off-by: Bernd Hufmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong branch. Please provide the identifier changes on top of latest in master branch.
Use CDT's cppFilt to demange c++ names if available. Signed-off-by: Matthew Khouzam <[email protected]>
1a79fbe
to
00da834
Compare
Can help for diagnosis/debugging [Added] JVM version to identifier service Signed-off-by: Matthew Khouzam <[email protected]>
00da834
to
08937a0
Compare
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like that it contains commits that are already merged, as well it's looks like it's based on stable-10.2 branch instead of master. Could you please rebase it on recent master?
No description provided.