Remove references to the incubator callstack #18
Conversation
arfio
changed the title
There was a problem hiding this comment.
I noticed that the ROCM plugins still depend on the incubator callstack. Additionally, the trace server also includes the incubator.core plug-in. Both should be addressed as well.
Could you please update that or let me know if have a different plan for those?
Thanks
Bernd
|
Trace Compass baseline build is available and this PR doesn't have any compilation errors anymore. However, there are some test errors which need to be addressed as well: |
arfio
force-pushed
the
replacing-callstack
branch
2 times, most recently
from
794a1c0 to
96d2018
Compare
|
The ROCm plugin will be updated separately, the incubator callstack and the ROCm plugin were removed from the trace server. The incubator analysis was kept because the trace event plugin is dependent on the aspects. |
There was a problem hiding this comment.
I'm ok to handle ROCm in a separated PR.
I noticed that the feature.xml files still have the dependencies to the incubator callstack plug-ins listed. I think they should be removed as will as part of the PR.
While checking the feature.xml files. I noticed that the XML defined call stack have not been migrate to mainline (package: . org.eclipse.tracecompass.incubator.internal.callstack.core.xml.callstack). The plug-in org.eclipse.tracecompass.incubator.tracecompass.core defines a build-in xml analysis (GroupedTasks.xml) and org.eclipse.tracecompass.incubator.traceevent.core defines another one (GroupedTasksTraceEvent.xml). These 2 corresponding features.xml cannot have the incubator callstack dependencies removed just yet.
So, I suggest to handle the xml analysis in a separate PR because it needs to be migrated first to mainline Trace Compass. However, please update this PR to update all relevant feature.xml files. WDYT?
|
Good catch, I agree with you. Do you think the xml analysis should be added to org.eclipse.tracecompass.analysis.profiling.core or org.eclipse.tracecompass.tmf.analysis.xml.core ? I personally think xml would be better. |
I think it should be part of |
Signed-off-by: Arnaud Fiorini <[email protected]>
Signed-off-by: Arnaud Fiorini <[email protected]>
Signed-off-by: Arnaud Fiorini <[email protected]>
Signed-off-by: Arnaud Fiorini <[email protected]>
Signed-off-by: Arnaud Fiorini <[email protected]>
Signed-off-by: Arnaud Fiorini <[email protected]>
Signed-off-by: Arnaud Fiorini <[email protected]>
Signed-off-by: Arnaud Fiorini <[email protected]>
Signed-off-by: Arnaud Fiorini <[email protected]>
Signed-off-by: Arnaud Fiorini <[email protected]>
Signed-off-by: Arnaud Fiorini <[email protected]>
arfio
force-pushed
the
replacing-callstack
branch
from
96d2018 to
1f704eb
Compare
This PR is intended to resolve the issue #12
Some classes were not moved to profiling.core so this patch is dependent on eclipse-tracecompass/org.eclipse.tracecompass#51
This fixes the following projects:
[Fixes] remove incubator callstack dependencies