Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROCm to be more generic #20

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

arfio
Copy link
Contributor

@arfio arfio commented Apr 10, 2024

This change will update the ROCm plugin to be more generic.
It adds a GPU plugin that generalizes the ROCm analysis and a layout definition to ROCm.

[Added] GPU plugin
[Added] RocmApiEventLayout and other classes to work with the GPU plugin
[Fixed] Dockerfile alpine version

@arfio arfio changed the title Update ROCm to be more generic WIP: Update ROCm to be more generic Apr 10, 2024
@arfio arfio marked this pull request as draft July 16, 2024 16:10
@arfio arfio changed the title WIP: Update ROCm to be more generic Update ROCm to be more generic Jul 16, 2024
@arfio arfio marked this pull request as ready for review July 19, 2024 12:55
arfio added 2 commits July 19, 2024 09:12
This module describes an event layout that every trace generated from a
GPU runtime should be able to implement. This allows the timeline
analysis to be more generic and less being subject to changes related to
changes to the tracer.

[Added] Generic timeline analysis for GPU traces
[Added] GPU trace event layout interface

Signed-off-by: Arnaud Fiorini <[email protected]>
As a new plugin was added to generate CTF traces with different event
types and format, these new analysis and trace were added to support
this new type. Each API function now has its own event type, and some
fields are now passed as context fields.

As this change uses the tracecompass.analysis.callstack and the rocm
plugin depends on it, the callstack plugin was added as a dependency
to the trace server.

[Added] New ROCm trace type to support new plugin
[Added] New ROCm CallStack that displays API and GPU activity

Signed-off-by: Arnaud Fiorini <[email protected]>
Copy link
Contributor

@MatthewKhouzam MatthewKhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@arfio arfio merged commit d540603 into eclipse-tracecompass-incubator:master Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants