Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix NPE when fetch a trace by UUID and it's not available #89

Conversation

bhufmann
Copy link
Contributor

@bhufmann bhufmann commented Oct 1, 2024

Fixes regression introduced by pull request:
#79

[Fixed] NPE when fetch a trace by UUID and it's not available

Signed-off-by: Bernd Hufmann [email protected]

Fixes regression introduced by pull request:
eclipse-tracecompass-incubator#79

[Fixed] NPE when fetch a trace by UUID and it's not available

Signed-off-by: Bernd Hufmann <[email protected]>
@bhufmann bhufmann requested a review from PatrickTasse October 1, 2024 19:05
Copy link
Contributor

@arfio arfio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this because of failing test in the tsp-python-client CI, after troubleshooting, I noticed this PR was fixing this issue, and applying the patch fixed it.
This looks perfect and adds regression tests, thank you !

@bhufmann
Copy link
Contributor Author

bhufmann commented Oct 4, 2024

I noticed this because of failing test in the tsp-python-client CI, after troubleshooting, I noticed this PR was fixing this issue, and applying the patch fixed it. This looks perfect and adds regression tests, thank you !

Thanks for the review. Yes, it fixes the issue. But, we found another related issue (i.e. unnecessary instantiating of trace resources) which is addressed with #90/#91. This PR will be obsolete after #90/#91 are merged.

@bhufmann
Copy link
Contributor Author

bhufmann commented Oct 4, 2024

Fixed with #90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants