Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uftrace] support C++ name Demangling in uftrace traces #95

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[uftrace] support C++ name Demangling in uftrace traces #95

merged 1 commit into from
Nov 27, 2024

Conversation

MatthewKhouzam
Copy link
Contributor

@MatthewKhouzam MatthewKhouzam commented Oct 10, 2024 •
edited
Loading

This patch allows uftrace traces of C++ programs to resolve symbols in a human readable.

Basically the trace contains the symbol 3barI5emptyLi17EE it will display bar<empty, 17> instead.

@MatthewKhouzam MatthewKhouzam marked this pull request as draft October 10, 2024 16:43
@MatthewKhouzam MatthewKhouzam marked this pull request as ready for review November 27, 2024 16:30
bhufmann
bhufmann requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message still has a change-id. Also, there is no PR description to explain what it does. The PR title should be updated as well.

Please update this PR accordingly.

@MatthewKhouzam
uftrace: demangle c++ names
01be4e6 
Use CDT's cppFilt to demange c++ names if available.

Signed-off-by: Matthew Khouzam <[email protected]>
@MatthewKhouzam MatthewKhouzam changed the title Cpp uftrace [uftrace] support C++ name Demangling in uftrace traces Nov 27, 2024
@MatthewKhouzam
Copy link
Contributor Author

vec.zip
Here is a test. Careful with the zip. ;)

bhufmann
bhufmann approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@MatthewKhouzam MatthewKhouzam merged commit 39e687b into eclipse-tracecompass-incubator:master Nov 27, 2024
2 checks passed
@MatthewKhouzam MatthewKhouzam deleted the cpp-uftrace branch November 27, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhufmann bhufmann bhufmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewKhouzam @bhufmann