fix: fixed property get naming to map

eclipse-tractusx · Jan 8, 2024 · 2ce9c46 · 2ce9c46
1 parent 5d67e28
commit 2ce9c46
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/...java/org/eclipse/tractusx/digitalproductpass/http/controllers/api/ContractController.java b/...java/org/eclipse/tractusx/digitalproductpass/http/controllers/api/ContractController.java
@@ -148,7 +148,7 @@ public Response create(@Valid @RequestBody DiscoverySearch searchBody) {
             }
             List<String> bpnList = new ArrayList<>();
             for(BpnDiscovery bpnDiscovery : bpnDiscoveries){
-                bpnList.addAll(bpnDiscovery.getBpnNumbers());
+                bpnList.addAll(bpnDiscovery.mapBpnNumbers());
             }
             if(bpnList.size() == 0){
                 response.message = "The asset was not found in the BPN Discovery!";

diff --git a/...ss/src/main/java/org/eclipse/tractusx/digitalproductpass/models/catenax/BpnDiscovery.java b/...ss/src/main/java/org/eclipse/tractusx/digitalproductpass/models/catenax/BpnDiscovery.java
@@ -45,9 +45,6 @@ public class BpnDiscovery {
     @JsonProperty("bpns")
     List<BpnEndpoint> bpns;
 
-    @JsonProperty("bpnNumbers")
-    List<String> bpnNumbers;
-
     /** CONSTRUCTOR(S) **/
     @SuppressWarnings("Unused")
     public BpnDiscovery(List<BpnEndpoint> bpns) {
@@ -68,7 +65,8 @@ public void setBpns(List<BpnEndpoint> bpns) {
     }
 
     /** METHODS **/
-    public List<String> getBpnNumbers(){
+
+    public List<String> mapBpnNumbers(){
         return bpns.stream().map(
                 BpnEndpoint::getValue
         ).collect(Collectors.toList());

diff --git a/dpp-backend/digitalproductpass/src/test/java/services/CatenaXServiceTest.java b/dpp-backend/digitalproductpass/src/test/java/services/CatenaXServiceTest.java
@@ -261,7 +261,7 @@ void getBpnDiscovery() {
         BpnDiscovery bpnDiscoveryEndpoint = (BpnDiscovery) jsonUtil.bindObject(bpnDiscoveryList.get(0), BpnDiscovery.class);
 
         assertEquals(1, bpnDiscoveryList.size());
-        assertTrue(bpnDiscoveryEndpoint.getBpnNumbers().contains(bpn));
+        assertTrue(bpnDiscoveryEndpoint.mapBpnNumbers().contains(bpn));
         assertEquals(bpnResourceId, bpnDiscoveryEndpoint.getBpns().get(0).getResourceId());
 
     }