Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2º] - Release/v1.2.0 digital product pass: Support the Digital Product Pass aspect in the backend #135

Merged
merged 29 commits into from
Oct 30, 2023
Merged

[2º] - Release/v1.2.0 digital product pass: Support the Digital Product Pass aspect in the backend #135

merged 29 commits into from
Oct 30, 2023

Conversation

matbmoser
Copy link
Contributor

Why we create this PR?

To add the Digital Product Passports in the application with retro compatibility of Battery Passports.

What we want to achieve with this PR?

Allow for the application to retrieve passports with the new created model "Digital Product Pass" while keep accepting the old model of Battery Passports.

What is new?

  • Removed the passport's version requirement
  • The Submodels are search by their SemanticId instead of idShort parameter.
  • New class for the new model of Digital Product Passport.
  • The application retrieves any type of passport aspect from a submodel endpoint (searching by semanticId)
  • Fixed a bug related to the discovery service when more than one search endpoint would be available
  • Removed version from the Search Api call

dsrparracho and others added 22 commits September 18, 2023 09:51
@dsrparracho
feat: fixed a missing call on searchSubmodel3BySemanticId method for …
f7f1818 
…dpp search
@dsrparracho
feat: fixed issue in getting submodel by semanticId method
370b578
@dsrparracho
feat: fix typo on Submmodel3 class in jsonProperty name
037ac68
@matbmoser
Merge branch 'eclipse-tractusx:main' into feature/cmp-870/change-sear…
715867a 
…ch-dpp
merge: solved merge conflict in submodel3
6dee2ca
fix: fixed multiple bpn + edc endpoints search in discovery service
6b81698
@dsrparracho
feat: fixed the semanticId model in the Submodel3 class
4e97960
fix: added missing contructor and the missing static reference
1c305f1
fix: fixed set is digital product pass
3ccc69b
fix: removed boolean that specifies if is DPP
85158b6
fix: added digital product pass when receiving the data
d585e1e
fix: fixed metadata and aditional information as jsonNode
0e8b20c
@dsrparracho
feat: change code to search for both digital product and battery passes
3a2a64f
@dsrparracho
feat: deleted debug logs and added semanticId into Status class
e59d23e
feat: added semantic id filtering for dynamic passes
69cf589
fix: parse passport by aspect type
b01f762
fix: parse passport by aspect type
0cfa7f8 
mend
@dsrparracho
fix: added logs to understand an issue with missing endpoint for subm…
e1f9f8b 
…odel
@dsrparracho
fix: added logs in appController and type globalreference to search f…
c54caf6 
…or semantiId
@dsrparracho
added GlobalReference to search semanticIds from DPP submodels
0718403
merge: resolved merge conflicts with develop
2757279
@matbmoser
Merge pull request #177 from catenax-ng/feature/cmp-870/change-search…
8cf72c5 
…-dpp

Feature/cmp 870/change search dpp
@matbmoser matbmoser added enhancement New feature or request backend Issue or PR connected to the backend application labels Oct 12, 2023
@matbmoser matbmoser changed the title Release/v1.2.0 digital product pass: Support the Digital Product Pass aspect in the backend [7º] - Release/v1.2.0 digital product pass: Support the Digital Product Pass aspect in the backend Oct 12, 2023
@matbmoser matbmoser added this to the v1.2.0 milestone Oct 12, 2023
@matbmoser matbmoser force-pushed the release/v1.2.0-digital-product-pass branch 4 times, most recently from cc05243 to 6db6d28 Compare October 13, 2023 09:05
@matbmoser matbmoser force-pushed the release/v1.2.0-digital-product-pass branch from 6db6d28 to 25e9e41 Compare October 13, 2023 09:20
@matbmoser matbmoser force-pushed the release/v1.2.0-digital-product-pass branch from 25e9e41 to b16e869 Compare October 13, 2023 09:46
@matbmoser matbmoser force-pushed the release/v1.2.0-digital-product-pass branch 5 times, most recently from 82cc2be to d08b14d Compare October 16, 2023 10:37
@matbmoser matbmoser force-pushed the release/v1.2.0-digital-product-pass branch from d08b14d to f452a19 Compare October 16, 2023 12:27
@matbmoser matbmoser changed the title [7º] - Release/v1.2.0 digital product pass: Support the Digital Product Pass aspect in the backend [1º] - Release/v1.2.0 digital product pass: Support the Digital Product Pass aspect in the backend Oct 19, 2023
@matbmoser matbmoser changed the title [1º] - Release/v1.2.0 digital product pass: Support the Digital Product Pass aspect in the backend [2º] - Release/v1.2.0 digital product pass: Support the Digital Product Pass aspect in the backend Oct 19, 2023
@matbmoser matbmoser merged commit a889de8 into eclipse-tractusx:main Oct 30, 2023
5 checks passed
@matbmoser matbmoser deleted the release/v1.2.0-digital-product-pass branch October 30, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend Issue or PR connected to the backend application enhancement New feature or request
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@matbmoser @dsrparracho