Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ 16° ] - Release/v2.1.0/legal notice: Added notice.md file and update workflows #201

Merged
merged 12 commits into from
Feb 2, 2024
Merged

[ 16° ] - Release/v2.1.0/legal notice: Added notice.md file and update workflows #201

merged 12 commits into from
Feb 2, 2024

Conversation

saudkhan116
Copy link
Contributor

Why we create this PR?

This PR contains the following changes:

  • Worked on a new TRG diccussed here TRG new: Docker file notice · Issue #360
  • Added notice.md to include "Notice for docker images" section to be only part of DockerHub description
  • Updated Git actions versions in docker workflows and setup-java action
  • Updated "Notice for docker images" section in a root README.md file
  • Refactor docker workflows

What we want to achieve with this PR?

To be compliant with the TRG requirement TRG-4.06

What is new?

Added

  • Added notice.md to include "Notice for docker images" section to be only part of DockerHub description

Updated

  • Updated Git actions versions in docker workflows and setup-java action
  • Refactor docker workflows
  • Updated "Notice for docker images" section in a main README.md

@saudkhan116 saudkhan116 requested a review from matbmoser February 2, 2024 14:22
@saudkhan116 saudkhan116 changed the title Release/v2.1.0/legal notice: Added notice.md file [ 16° ] - Release/v2.1.0/legal notice: Added notice.md file Feb 2, 2024
@saudkhan116 saudkhan116 added the documentation Improvements or additions to documentation label Feb 2, 2024
@saudkhan116 saudkhan116 added this to the v2.1.0 milestone Feb 2, 2024
@saudkhan116 saudkhan116 changed the title [ 16° ] - Release/v2.1.0/legal notice: Added notice.md file [ 16° ] - Release/v2.1.0/legal notice: Added notice.md file and update workflows Feb 2, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@matbmoser matbmoser modified the milestones: v2.1.0, v2.0.3 Feb 2, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2024
View reviewed changes
.github/workflows/publish-dpp-backend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-backend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-frontend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-frontend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-frontend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-frontend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-frontend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-backend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-backend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-backend-docker-image.yml Dismissed Show dismissed Hide dismissed
matbmoser
matbmoser approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runned Ip checks and its apprioved

@matbmoser
Copy link
Contributor

Dismissed KICS warnings

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2024
View reviewed changes
deployment/local/storage/pv-data.yaml Dismissed Show dismissed Hide dismissed
@saudkhan116 saudkhan116 merged commit a57c5f3 into eclipse-tractusx:main Feb 2, 2024
8 checks passed
@saudkhan116 saudkhan116 deleted the release/v2.1.0/legal-notice branch February 2, 2024 20:06
@saudkhan116 saudkhan116 mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbmoser matbmoser matbmoser approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Digital Product Pass
Archived in project
Milestone
v2.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@saudkhan116 @matbmoser