Feature/verification backend: Added Verification Add-on + Modularized Backend to Core #342
Conversation
Co-authored-by: Mathias Brunkow Moser <[email protected]> Co-authored-by: Muhammad Saud Khan <[email protected]> Co-authored-by: Mathias Moser <[email protected]> Co-authored-by: Saud Khan <[email protected]>
Co-authored-by: Mathias Brunkow Moser <[email protected]> Co-authored-by: Muhammad Saud Khan <[email protected]> Co-authored-by: Mathias Moser <[email protected]> Co-authored-by: Saud Khan <[email protected]>
…ation Co-authored-by: Mathias Brunkow Moser <[email protected]> Co-authored-by: Muhammad Saud Khan <[email protected]> Co-authored-by: Mathias Moser <[email protected]> Co-authored-by: Saud Khan <[email protected]> Co-authored-by: Mathias Brunkow Moser <[email protected]>
matbmoser
added
backend
|
I have move the complete backend files to another folder, because of this there is so many lines of code. All the code has been done by me. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** | ||
| * Initiates the main needed variables for Data Transfer Service by loading from the environment variables and Vault. | ||
| **/ | ||
| public void init(Environment env) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
There was a problem hiding this comment.
The license headers are not correct in verification source code, please correct them.
The correct one is:
"Tractus-X - Digital Product Passport Verification Add-on
Copyright (c) 2023 BMW AG
Copyright (c) 2023 CGI Deutschland B.V. & Co. KG
Copyright (c) 2024 Contributors to the Eclipse Foundation
See the NOTICE file(s) distributed with this work for additional
information regarding copyright ownership.
This program and the accompanying materials are made available under the
terms of the Apache License, Version 2.0 which is available at
https://www.apache.org/licenses/LICENSE-2.0.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express or implied. See the
License for the specific language govern in permissions and limitations
under the License.
SPDX-License-Identifier: Apache-2.0"
| @@ -0,0 +1,194 @@ | |||
| /********************************************************************************* | |||
| * | |||
| * Tractus-X - Digital Product Pass Application | |||
There was a problem hiding this comment.
Is it not a verification add-on in license header?
| @@ -0,0 +1,69 @@ | |||
| /********************************************************************************* | |||
| * | |||
| * Tractus-X - Digital Product Pass Application | |||
| * Tractus-X - Digital Product Pass Application | ||
| * | ||
| * Copyright (c) 2022, 2024 BMW AG, Henkel AG & Co. KGaA | ||
| * Copyright (c) 2022, 2024 CGI Deutschland B.V. & Co. KG |
There was a problem hiding this comment.
Since the working on dpp-verification was started in year 2023, no?
Copyright (c) 2022, 2024 CGI Deutschland B.V. & Co. KG -> Copyright (c) 2023 CGI Deutschland B.V. & Co. KG?
Also, the license headers are not aligned as in other files/resources from verification.
There was a problem hiding this comment.
All copyright license headers are corrected and updated in PR #351
No IP issues found
LGTM
|
Ok all set to do the merge |
Why we create this PR?
The feature eclipse-tractusx/sig-release#655 requested us to create the digital product pass verification for the consumer backend.
What we want to achieve with this PR?
Be able to verify the data incoming from the digital twin behind an EDC against a wallet that issued the credential.
What is new?
Added
Updated
PR Linked to:
Closes eclipse-tractusx/sig-release#655