Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore|sde-backend] Docker notice.md added #101

Merged
merged 10 commits into from
Feb 26, 2024

Conversation

adityagajbhiye9
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 commented Feb 22, 2024

Description

  • Docker notice.md added.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

- update for docker notice
@adkumar1
Copy link
Contributor

Need to remove "Notice for Docker image" from README.md
& create a link in README.md referering DOCKER_NOTICE.md

- Readme update for docker notice
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adkumar1
Copy link
Contributor

Looks fine now

Copy link
Contributor

@hzierer hzierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think you have to adjust your workflow too to include the newly created file instead of the default README.
    see the last line ( readme-filepath ... ) here
  • please rename the file to notice.md as stated in the TRG

- docker notice file path update.
@adityagajbhiye9
Copy link
Contributor Author

@hzierer As notice file already exit created the docker_notice.md file.

@hzierer
Copy link
Contributor

hzierer commented Feb 26, 2024

@hzierer As notice file already exit created the docker_notice.md file.

yeah, sorry my bad. Haven't described it in detail enough. The "notice for docker" has to be in the same directory as the Docker file - so it is no problem to be named notice.md.

Sorry for any inconveniences caused.

@adityagajbhiye9
Copy link
Contributor Author

@hzierer please review.

@adityagajbhiye9
Copy link
Contributor Author

@hzierer As notice file already exit created the docker_notice.md file.

yeah, sorry my bad. Haven't described it in detail enough. The "notice for docker" has to be in the same directory as the Docker file - so it is no problem to be named notice.md.

Sorry for any inconveniences caused.

No worries :)

Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FaGru3n FaGru3n merged commit bcccdd4 into eclipse-tractusx:main Feb 26, 2024
3 checks passed
@FaGru3n FaGru3n deleted the Notice branch February 26, 2024 13:19
@FaGru3n
Copy link
Contributor

FaGru3n commented Feb 26, 2024

sorry missed a upper case link in this PR that is not nessesary... so created a new one to fix but also don´t know your workflow how to change theese files...

will close it... right now #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants