-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore|sde-backend] Docker notice.md added #101
Conversation
- Docker notice added.
- update for docker notice
Need to remove "Notice for Docker image" from README.md |
35c8cb2
to
5234176
Compare
- Readme update for docker notice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks fine now |
8c048c9
to
8902086
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think you have to adjust your workflow too to include the newly created file instead of the default README.
see the last line ( readme-filepath ... ) here - please rename the file to
notice.md
as stated in the TRG
- docker notice file path update.
@hzierer As notice file already exit created the docker_notice.md file. |
yeah, sorry my bad. Haven't described it in detail enough. The "notice for docker" has to be in the same directory as the Docker file - so it is no problem to be named notice.md. Sorry for any inconveniences caused. |
@hzierer please review. |
No worries :) |
rename to docker_notice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sorry missed a upper case link in this PR that is not nessesary... so created a new one to fix but also don´t know your workflow how to change theese files... will close it... right now #105 |
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: