Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix | Security issue fix 2405 #169

Merged
merged 13 commits into from
May 13, 2024
Merged

fix | Security issue fix 2405 #169

merged 13 commits into from
May 13, 2024

Conversation

sachinargade123
Copy link
Contributor

@sachinargade123 sachinargade123 commented May 13, 2024 •
edited
Loading

Description

Fixed

  • Security issue fixed.
  • Dependabot bump version fixes for 24/05

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

This was referenced May 13, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced May 13, 2024
Closed
Closed
Closed
Closed
Closed
Closed
ChetanT-System
ChetanT-System approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@ChetanT-System ChetanT-System left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@almadigabor
Copy link
Contributor

almadigabor commented May 13, 2024 •
edited
Loading

I've ran the dash tool, you can track the issues here:

[INFO] This content is either not correctly mapped by the system, or requires review.
[INFO] A review is required for maven/mavencentral/org.apache.commons/commons-csv/1.11.0.
[INFO] A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14690 .

github-advanced-security[bot]
github-advanced-security bot found potential problems May 13, 2024
View reviewed changes
...a/org/eclipse/tractusx/sde/edc/entities/request/policies/PolicyConstraintBuilderService.java
private List<String> getAndOwnerBPNIfNotExist(Policies policy, List<String> values) {

if (policy.getTechnicalKey().equals(BUSINESS_PARTNER_NUMBER) && !values.isEmpty()
&& !values.contains(manufacturerId) && (values.size() == 1 && !values.get(0).equals(""))) {

Check notice

Code scanning / CodeQL

Inefficient empty string test Note

Inefficient comparison to empty string, check for zero length instead.
@almadigabor almadigabor merged commit 6079f20 into eclipse-tractusx:main May 13, 2024
6 checks passed
@almadigabor almadigabor deleted the security_issue_fix_2405 branch May 13, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almadigabor almadigabor almadigabor approved these changes

@ChetanT-System ChetanT-System ChetanT-System approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sachinargade123 @almadigabor @ChetanT-System @adityagajbhiye9