-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove picture references to user-images #243
chore: remove picture references to user-images #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
Just have a look at my comment
And please also add the following as the issue requests:
"Please also enhance the 'How to contribute' guide with a description about how to manage images (upload to static/docs, create license file, link in the documentation...)."
And correct the PR title, I think you wanted to write user-images instead of catenax-ng.
Hi, before merging we need to validate what we merge first - in parallel following prs got created and might impact this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please adjust the cases of user-images in the following files:
https://github.com/catenax-ng/tx-portal-assets/blob/chore/remove-user-images/docs/developer/01.%20Onboarding/03.%20Registration%20Approval/03.%20Registration%20Approval%20Process.md
https://github.com/catenax-ng/tx-portal-assets/blob/chore/remove-user-images/docs/user/01.%20Onboarding/03.%20Registration%20Approval/03.%20Registration%20Approval%20Process.md
…ortal-assets into chore/remove-user-images
|
I'll merge this PR first and then solve potential conflicts and do the necessary adjustments for the mentioned PRs. |
Description
Why
Cleanup
Issue
Link to Github issue.
Checklist