Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): adjust provider callbackurl handling #1227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jan 8, 2025

Description

When the provider callback url is removed the trigger provider callback steps are set to done and the await auto setup step is created

Why

If a offer subscription process is in progress and the provider callback url is removed by the provider it might occur that the process is stuck since the next step would be to trigger the provider callback, which must not be triggered anymore

Issue

Refs: #1175

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

when the provider callback url is removed the trigger provider callback steps are set to done and the await auto setup step is created

Refs: #1175
Copy link

sonarqubecloud bot commented Jan 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant