fix: user role description translations in en/de #1287
Conversation
|
|
@kunalgaurav-bmw @lavanya-bmw @manojava-gk please review |
evegufy
changed the base branch from
release/v2.3.0-RC3
to
release/v2.3.0-RC4
| CSVCells[0] === 'roles;description\r' || | ||
| CSVCells[0] === 'roles;description' | ||
| CSVCells[0] === 'roles;description_en;description_de\r' || | ||
| CSVCells[0] === 'roles;description_en;description_de' |
There was a problem hiding this comment.
The implemented solution wouldn't work with more than two languages in case we provide descriptions for additional languages in the future.
| Commercial Manager;Commercial Specialist can do the final approval of commercial request and trigger the payout;Der Handelsspezialist kann die endgültige Genehmigung des Handelsantrags vornehmen und die Auszahlung veranlassen. | ||
| Recycler;Recycler can buy recycled material;Recycler können recyceltes Material kaufen | ||
| Manager;This is only a test text in EN;Das is in Deutsch |
There was a problem hiding this comment.
the translations should not appear in this template. Instead we should have them together with the other translations in src/assets/locales.
|
Absolutely! However, as per my understanding, this is not a translation for some static labels or text. Instead, it pertains to user-driven role description translations, which are always handled through CSV uploads during the app creation phase. Based on the requirement, I made an addition to support the DE language, as per the reported bug. I also discussed this with @ybidois . The CSV upload process needs to be reconsidered to allow users the flexibility to edit role descriptions. Additionally, we need to evaluate how the UI will look if we expand to more than two languages. For the scope of this ticket, the bug needs to be resolved, but a discussion with UX is required before making any UI changes for role descriptions. |
Description
Updated the CSV file parsing journey in order to extract the German language translations for User role's description in process of App creation.
Changelog entry:
Why
we weren't handling the User Role's description in German language from CSV file template.
Issue
#1288
Checklist