Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: masked confidentail technical user fields #1398

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Usmanfee
Copy link
Contributor

@Usmanfee Usmanfee commented Dec 10, 2024

Description

Removed Password type fields from OSP callback config and IDP config screen because requirement is to make them text based Input while Adding/Updating the configuration of either of them and also made Technical User detail screen protected for the sensitive information with masking and toggleable them by introducing an eye icon.

- **Changelog entry**
  - Technical User | IDP config | OSP callback config
  - Introduced Masking for Sensitive information in Technical User Detail Section [#1399](https://github.com/eclipse-tractusx/portal-frontend/issues/1399)

Why

Best Practice to hide the sensitive information by default and whenever Customer support team wants to prepare Demo video of Portal they says sensitive information should be hidden e.g., Passwords, secrets from Technical User Detail.

Issue

#1399

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

@Usmanfee Usmanfee marked this pull request as ready for review December 10, 2024 10:43
@Usmanfee Usmanfee marked this pull request as draft December 10, 2024 10:49
Copy link
Contributor

@JordanGerada3 JordanGerada3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & successfully tested locally

@Usmanfee Usmanfee marked this pull request as ready for review December 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants