Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies workflow): refactor dependency conflict resolution logic #1524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saadanzari
Copy link
Member

@saadanzari saadanzari commented Mar 4, 2025

Description

Update obsolete logic in Dependencies.yaml for "Check if dependencies were changed".

Why

After the improvement done during of #1306, it is noticed that the check if the dependencies file was changed is obsolete.
The relevant steps affected by this constraint should be executed every time the workflow is triggered.

- **Dependencies Workflow**:
  - Update logic for Dependencies workflow [#1524](https://github.com/eclipse-tractusx/portal-frontend/pull/1524)

Issue

#1518

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link

sonarqubecloud bot commented Mar 4, 2025

@saadanzari saadanzari requested a review from evegufy March 4, 2025 14:22
@saadanzari saadanzari changed the base branch from main to release/v2.4.0-RC2 March 4, 2025 14:23
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an improvement, no fix. Just an obsolete check that can be remove not a fix, as also state in the issue #1518, please change title and description accordingly.
Please also raise PR against against, it's not at all urgent and does not need to go into the release.

@saadanzari saadanzari changed the base branch from release/v2.4.0-RC2 to main March 4, 2025 14:42
@saadanzari saadanzari self-assigned this Mar 4, 2025
@saadanzari saadanzari added the enhancement New feature or request label Mar 4, 2025
@saadanzari saadanzari added this to the Release 25.06 milestone Mar 4, 2025
@saadanzari saadanzari changed the title fix(dependencies workflow): removed conflicting logic for dependencies were changed chore(dependencies workflow): update conflicting logic for dependencies workflow Mar 4, 2025
@saadanzari saadanzari requested a review from evegufy March 4, 2025 14:45
@saadanzari saadanzari changed the title chore(dependencies workflow): update conflicting logic for dependencies workflow feat(dependencies workflow): update conflicting logic for dependencies workflow Mar 4, 2025
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the type feat does imply some change to source code, which isn't the case here. I in general, I recommend you read up on the different types of conventional commits (IMO chore or build are suitable here).
also the pr title is quite redundant, referring twice to the dependencies flow, please improve.

@saadanzari saadanzari changed the title feat(dependencies workflow): update conflicting logic for dependencies workflow chore(dependencies workflow): refactor dependency conflict resolution logic Mar 4, 2025
@saadanzari
Copy link
Member Author

saadanzari commented Mar 4, 2025

@evegufy since there is some logic that's been modified for existing functionality, but it was in .workflow file, there was some confusion I added chore first then renamed it as feat. the requested updates are done in this PR.

@saadanzari saadanzari requested a review from evegufy March 4, 2025 15:03
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

2 participants