-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dependencies workflow): refactor dependency conflict resolution logic #1524
base: main
Are you sure you want to change the base?
chore(dependencies workflow): refactor dependency conflict resolution logic #1524
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just an improvement, no fix. Just an obsolete check that can be remove not a fix, as also state in the issue #1518, please change title and description accordingly.
Please also raise PR against against, it's not at all urgent and does not need to go into the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the type feat
does imply some change to source code, which isn't the case here. I in general, I recommend you read up on the different types of conventional commits (IMO chore or build are suitable here).
also the pr title is quite redundant, referring twice to the dependencies flow, please improve.
@evegufy since there is some logic that's been modified for existing functionality, but it was in .workflow file, there was some confusion I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Update obsolete logic in Dependencies.yaml for "Check if dependencies were changed".
Why
After the improvement done during of #1306, it is noticed that the check if the dependencies file was changed is obsolete.
The relevant steps affected by this constraint should be executed every time the workflow is triggered.
Issue
#1518
Checklist