Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add autoFocus as new props #101

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Feb 23, 2024

Description

add autoFocus as a new prop and provide true as default value

Why

autoFocus is creating issues of unhelpful scroll in several pages.

Issue

eclipse-tractusx/portal-frontend#431

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@manojava-gk manojava-gk marked this pull request as ready for review February 23, 2024 11:09
Copy link
Contributor

@nidhigarg-bmw nidhigarg-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manojava-gk manojava-gk requested a review from evegufy February 26, 2024 06:59
@manojava-gk
Copy link
Contributor Author

@evegufy Can you merge this PR?

@evegufy evegufy changed the title feat(table): autoFocus as new props to the table feat(table): add autoFocus as new props to the table Feb 26, 2024
@evegufy evegufy changed the title feat(table): add autoFocus as new props to the table feat(table): add autoFocus as new props Feb 26, 2024
@evegufy evegufy merged commit d11b922 into eclipse-tractusx:main Feb 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants