Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): fix misspelled properties #112

Merged
merged 3 commits into from
Mar 11, 2024
Merged

fix(css): fix misspelled properties #112

merged 3 commits into from
Mar 11, 2024

Conversation

oyo
Copy link
Contributor

@oyo oyo commented Mar 11, 2024

Description

Fixed properties written in kebap-case where camelCase is required

Why

In the browser dev tools we got an ugly warning message which is removed now.

Issue

n/a

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@oyo oyo requested a review from evegufy March 11, 2024 13:49
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general but even though this does seem like a small fix/change, IMO it's breaking, shouldn't the minor be raised? Be aware, we (portal app) aren't the only ones using this library.
And if we're already on spelling issues, could you maybe also search for "uploadProgess" and fix it? "Progress" is misspelled.

@oyo
Copy link
Contributor Author

oyo commented Mar 11, 2024

LGTM in general but even though this does seem like a small fix/change, IMO it's breaking, shouldn't the minor be raised? Be aware, we (portal app) aren't the only ones using this library. And if we're already on spelling issues, could you maybe also search for "uploadProgess" and fix it? "Progress" is misspelled.

@evegufy Increasing the minor version would be advised if any spelling in the interface to the library users has changed - but here I only fixed misspelled css attributes used within the components. So any code using the library is compiling as before, only the behavior of the component has slightly changed - not showing the warning in the dev console any more.

uploadProgess is such a case: changing this would require a minor version upgrade, another option would be to support both spellings - the incorrect and the correct one and set the incorrect to deprecated. That way existing code doesn't have to be changed immediately.

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oyo thanks for the explanation!

@oyo oyo merged commit 591736f into main Mar 11, 2024
8 checks passed
@oyo oyo deleted the fix/misspelled-css branch March 11, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants