feat(card): create new content card #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nidhigarg-bmw
requested review from
oyo,
manojava-gk and
lavanya-bmw
and removed request for
oyo
oyo
requested changes
Apr 2, 2024
| title: string | ||
| chipText: string | ||
| bpnHeading?: string | ||
| bpnDetails?: string |
There was a problem hiding this comment.
please remember the shared components should not contain any business specific details, so the prefix bpn for business partner number is not good here. Let's simply call it "heading" and "detail"
| height: '60px', | ||
| '-webkit-line-clamp': '2', | ||
| display: '-webkit-box', | ||
| '-webkit-box-orient': 'vertical', |
There was a problem hiding this comment.
if we have any CSS properties starting with "-webkit-..." we should also add the standard version:
'-webkit-box-orient': 'vertical',
boxOrient: 'vertical',
same with lineClamp two lines before
There was a problem hiding this comment.
@oyo Made the changes as requested
|
oyo
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why
Added new Card to use them in portal frontend
Issue
eclipse-tractusx/portal-frontend#613
Checklist
Please delete options that are not relevant.