feat(table): update table to support error messages #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/components/basic/Table/index.tsx
Outdated
| const renderErrorMessage = () => { | ||
| if (error == null) { | ||
| return <Typography variant="body2">{noRowsMsg ?? 'No rows'}</Typography> | ||
| } else if (error != null) { |
Check notice
Code scanning / CodeQL
Unneeded defensive code Note
There was a problem hiding this comment.
Removed Unneeded defensive code
oyo
requested changes
Jul 12, 2024
src/components/basic/Table/index.tsx
Outdated
| const renderErrorMessage = () => { | ||
| if (error == null) { | ||
| return <Typography variant="body2">{noRowsMsg ?? 'No rows'}</Typography> | ||
| } else { |
There was a problem hiding this comment.
we don't need else if the previous if returns 100% sure. Change from
- if (something) {
- return x
- } else {
- doMore()
- }to
+ if (something) {
+ return x
+ }
+ doMore()
oyo
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated table component to support error messages
Why
to enhance table component to support error messages
Issue
eclipse-tractusx/portal-frontend#891
eclipse-tractusx/portal-frontend#888
Checklist
Please delete options that are not relevant.