chore(all components): added classNames and variants names where possible #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saadanzari Notice the failed check. Please update DEPENDENCIES to fix:
|
@oyo, I actually tried that but still no luck. please refer to this commit 6df7e19 |
oyo
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add classNames and variants names where possible for adding customization support to use them in different applications.
Why
MUI applies their own classes on elements which makes it difficult to style within different applications.
Add ClassNames on elements for better styling support in other applications which are using portal-shared-components as npm package, so that we can easily modify the color themes in the application level .
Issue
#229
Checklist