-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: linting error and warning in storybook #248
fix: linting error and warning in storybook #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general but two minor things:
Since we are releasing a new version on every PR merge please provide a short summary of your changes at the top of CHANGELOG.md
With .stories.tsx
not ignored any more there are two linter complaints about strings not using single quotes which causes PR check failing. Check with yarn lint
Both changes are done and pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now - thanks for your contribution
Hi @shahmargi12 could you please resolve the conflicts? I'll merge the pr afterwards. Sorry for the inconvenience. |
Quality Gate passedIssues Measures |
Hi @evegufy , i have resolved the conflicts and also update package version to 3.0.31. |
Description
Why
Enabled linting in the Storybook file, which was previously disabled. Fixed all linting errors that occurred as a result.
Issue
#144
Checklist