Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linting error and warning in storybook #248

Merged

Conversation

shahmargi12
Copy link
Contributor

@shahmargi12 shahmargi12 commented Jul 24, 2024

Description

  • Fix all the linting issue in library

Why

Enabled linting in the Storybook file, which was previously disabled. Fixed all linting errors that occurred as a result.

Issue

#144

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@evegufy evegufy requested a review from oyo July 25, 2024 12:05
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general but two minor things:

Since we are releasing a new version on every PR merge please provide a short summary of your changes at the top of CHANGELOG.md

With .stories.tsx not ignored any more there are two linter complaints about strings not using single quotes which causes PR check failing. Check with yarn lint

@shahmargi12 shahmargi12 requested a review from oyo July 30, 2024 13:18
@shahmargi12
Copy link
Contributor Author

Looks good in general but two minor things:

Since we are releasing a new version on every PR merge please provide a short summary of your changes at the top of CHANGELOG.md

With .stories.tsx not ignored any more there are two linter complaints about strings not using single quotes which causes PR check failing. Check with yarn lint

Both changes are done and pushed.

oyo
oyo previously approved these changes Jul 30, 2024
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now - thanks for your contribution

@evegufy
Copy link
Contributor

evegufy commented Aug 5, 2024

Hi @shahmargi12 could you please resolve the conflicts? I'll merge the pr afterwards. Sorry for the inconvenience.

Copy link

sonarqubecloud bot commented Aug 6, 2024

@shahmargi12
Copy link
Contributor Author

Hi @shahmargi12 could you please resolve the conflicts? I'll merge the pr afterwards. Sorry for the inconvenience.

Hi @evegufy , i have resolved the conflicts and also update package version to 3.0.31.

@evegufy evegufy self-assigned this Aug 7, 2024
@evegufy evegufy merged commit 6a2d5a8 into eclipse-tractusx:main Aug 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

3 participants