Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SearchInput component with debounce functionality #250

Merged

Conversation

charmi-v
Copy link
Contributor

Description

Component: SearchInput

  • Modified the component with new props to manage debounce functionality.
  • Added a test file
  • Added required mock files for running jest test
  • Added a documentation file describing the component

Why

New Feature: Enhanced the SearchInput component with debounce functionality.

Issue

#222

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@charmi-v charmi-v changed the title Feature (SearchInput) : added debounce functionality feat: SearchInput component with debounce functionality Jul 26, 2024
@charmi-v charmi-v changed the title feat: SearchInput component with debounce functionality feat: SearchInput component with debounce functionality Jul 26, 2024
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good contribution - but since we are publishing a new release on every PR merge please provide a short summary at the top of CHANGELOG.md

@charmi-v charmi-v requested a review from oyo July 30, 2024 12:31
oyo

This comment was marked as outdated.

Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evegufy pointed out missing license headers on all new files

@charmi-v charmi-v requested a review from oyo July 31, 2024 05:23
oyo
oyo previously approved these changes Jul 31, 2024
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@evegufy
Copy link
Contributor

evegufy commented Aug 7, 2024

Hi @charmi-v could you please resolve the conflicts? I'll merge the pr afterwards. Sorry for the inconvenience.

@evegufy evegufy self-assigned this Aug 7, 2024
Copy link

sonarqubecloud bot commented Aug 8, 2024

@charmi-v
Copy link
Contributor Author

charmi-v commented Aug 8, 2024

Hi @charmi-v could you please resolve the conflicts? I'll merge the pr afterwards. Sorry for the inconvenience.

Hello @evegufy ,
Conflicts have been resolved, and the package version has been updated to 3.0.32.

@evegufy evegufy merged commit 71062de into eclipse-tractusx:main Aug 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

3 participants