Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handleChange function causing issue while selecting values from selectList component #262

Conversation

shubhamv-ss
Copy link
Contributor

Description

Why

This change is necessary to address a critical issue where the SelectList component does not save the selected values upon form submission, or resets them to the default values. This issue affects the data integrity and user experience, as users expect their selections to be retained and accurately reflected in the submitted data.

  • Data Integrity: Ensuring that the selected values are correctly saved prevents data loss and maintains the integrity of the information submitted by the users.
  • User Experience: Users need to trust that their selections are preserved. Losing or resetting the selected values can lead to frustration and errors in data entry.
  • Workflow Continuity: Inaccurate data due to unsaved selections can disrupt workflows, leading to inefficiencies and potential issues in subsequent processes.

Dependencies

There are no additional dependencies required for this change. The fix involves modifying the existing SelectList component to ensure proper handling of the selected values.

Implementing this change will enhance the reliability and functionality of the SelectList component, ensuring that it meets user expectations and maintains accurate data handling across the application.

Issue

Checklist

Please delete options that are not relevant.

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shubhamv-ss
Copy link
Contributor Author

Is it good to merge this?
@evegufy @lavanya-bmw

@shubhamv-ss shubhamv-ss added priority PR needs to prioritized at review bug Something isn't working labels Aug 8, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shubhamv-ss could you please resolve the conflict?

@evegufy evegufy self-assigned this Aug 8, 2024
Copy link

sonarqubecloud bot commented Aug 8, 2024

@shubhamv-ss
Copy link
Contributor Author

Hi @shubhamv-ss could you please resolve the conflict?

Hi @evegufy ,
The conflicts have been addressed.

Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shubhamv-ss shubhamv-ss requested a review from evegufy August 8, 2024 13:36
@shubhamv-ss
Copy link
Contributor Author

Hey @evegufy , sorry to bother you again. My previous PR broke this component, but this new one should fix it. We're blocked on it atm, can you take a look today? Thanks

@evegufy evegufy merged commit 7deab44 into eclipse-tractusx:main Aug 9, 2024
8 checks passed
@evegufy
Copy link
Contributor

evegufy commented Aug 9, 2024

Hey @evegufy , sorry to bother you again. My previous PR broke this component, but this new one should fix it. We're blocked on it atm, can you take a look today? Thanks

@shubhamv-ss done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority PR needs to prioritized at review
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

4 participants