Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app & service subscription): fix search text clearing #371

Conversation

ss-nikunj
Copy link
Contributor

@ss-nikunj ss-nikunj commented Nov 4, 2024

Description

  • The Table component includes a search bar to filter results. However, users were unable to clear the search text after entering it without refreshing the page.
  • The search bar is integrated within the Toolbar component, where the onClearSearch method is implemented. However, the method was not being correctly passed down from the parent component, preventing it from functioning as expected.

Fix

  • Ensured that the onClearSearch method is properly passed from the parent component to enable text clearing in the search bar without needing a page refresh.

Issue

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

Changelog Entry

- **App & Service Subscription**:
    - Fixed issue preventing search text from being cleared in App & Service Subscription without a page refresh. [#370](https://github.com/eclipse-tractusx/portal-shared-components/issues/370)

@ss-nikunj ss-nikunj changed the title Fix App & Service Subscription Search Text Clearing Issue fix: App & Service Subscription Search Text Clearing Issue Nov 4, 2024
@ss-nikunj ss-nikunj requested review from oyo and manojava-gk and removed request for oyo November 4, 2024 06:42
@ss-nikunj ss-nikunj self-assigned this Nov 4, 2024
@ss-nikunj ss-nikunj added the bug Something isn't working label Nov 4, 2024
@ss-nikunj
Copy link
Contributor Author

Hi @MaximilianHauer, Can you please review this PR?

@manojava-gk
Copy link
Contributor

@ss-nikunj kindly add changelog entry and fix dependency issue

@ss-nikunj
Copy link
Contributor Author

Hi @manojava-gk, I have added a changelog entry to the description ( as per @evegufy mentioned in one of my PR ). I will resolve the dependency issue

@ss-nikunj ss-nikunj force-pushed the fix/app-service-subscription-clear-search-issue branch from 45a3652 to fafe401 Compare November 22, 2024 11:49
@MaximilianHauer
Copy link

MaximilianHauer commented Nov 26, 2024

lgtm but to make it perfect ensure that the changelog entry is embedded this makes it easy to copy paste it.
@ss-nikunj
image

@ss-nikunj
Copy link
Contributor Author

Hi @MaximilianHauer, As you mentioned I have modified the changelog entry.

@evegufy evegufy changed the title fix: App & Service Subscription Search Text Clearing Issue fix(app & service subscription): fix search text clearing Dec 4, 2024
@evegufy evegufy merged commit 43e9557 into eclipse-tractusx:main Dec 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

4 participants